Skip to content

Test swarm task admission through the read-task callback function - #2934

Open
ianton-ru wants to merge 1 commit into
Altinity:antalya-26.8from
ianton-ru:bugfix/antalya-26.8/swarm-task-admission-tests
Open

ianton-ru wants to merge 1 commit into
Altinity:antalya-26.8from
ianton-ru:bugfix/antalya-26.8/swarm-task-admission-tests

Conversation

@ianton-ru

Copy link
Copy Markdown

The swarm gtests copied the lock-then-send sequence into the test lambda, so they checked SharedMutex rather than the decision the read-task callback makes. Context::runWithSwarmTaskAdmission is that decision: it holds the admission lock across the enabled check and the send, then releases the lock before returning. TCPHandler and the gtests both call it.

StorageObjectStorageSwarm.* passes with --gtest_repeat=2.

Related: #2759

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Test the swarm task admission decision through the same function the read-task callback uses.

Documentation entry for user-facing changes

None.

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

…armTaskAdmission`

The gtests copied the lock protocol instead of calling the read-task callback path, so they did not check the production decision. Both now call the same function, so the tests exercise the code that decides whether a task request is sent.

Co-authored-by: Cursor <cursoragent@cursor.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant